[Erp5-report] r34788 jerome - in /erp5/trunk/products: ERP5/ ERP5Type/Core/

[nobody at svn.erp5.org]

Author: jerome
Date: Mon Apr 26 17:31:35 2010
New Revision: 34788

URL: http://svn.erp5.org?rev=34788&view=rev
Log:
drop support for immediate_reindex=True in newContent. Immediate reindexing is
a coding crime, we should not have an API for that.

Modified:
    erp5/trunk/products/ERP5/ERP5Site.py
    erp5/trunk/products/ERP5Type/Core/Folder.py

Modified: erp5/trunk/products/ERP5/ERP5Site.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/ERP5Site.py?rev=34788&r1=34787&r2=34788&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/ERP5Site.py [utf8] (original)
+++ erp5/trunk/products/ERP5/ERP5Site.py [utf8] Mon Apr 26 17:31:35 2010
@@ -1226,7 +1226,7 @@
     return None
 
   security.declareProtected(Permissions.AddPortalContent, 'newContent')
-  def newContent(self, id=None, portal_type=None, immediate_reindex=0, **kw):
+  def newContent(self, id=None, portal_type=None, **kw):
     """
       Creates a new content
     """
@@ -1240,10 +1240,8 @@
                                        ) # **kw) removed due to CMF bug
     new_instance = self[id]
 
-    if kw is not None:
+    if kw:
       new_instance._edit(force_update=1, **kw)
-    if immediate_reindex:
-      new_instance.immediateReindexObject()
     return new_instance
 
   security.declarePublic('getVisibleAllowedContentTypeList')

Modified: erp5/trunk/products/ERP5Type/Core/Folder.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Core/Folder.py?rev=34788&r1=34787&r2=34788&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Core/Folder.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/Core/Folder.py [utf8] Mon Apr 26 17:31:35 2010
@@ -112,9 +112,9 @@
 
   security.declarePublic('newContent')
   def newContent(self, id=None, portal_type=None, id_group=None,
-          default=None, method=None, immediate_reindex=0,
-          container=None, created_by_builder=0, activate_kw=None,
-          is_indexable=None, temp_object=0, reindex_kw=None, **kw):
+          default=None, method=None, container=None, created_by_builder=0,
+          activate_kw=None, is_indexable=None, temp_object=0, reindex_kw=None,
+          **kw):
     """Creates a new content.
     This method is public, since TypeInformation.constructInstance will perform
     the security check.
@@ -167,8 +167,8 @@
       # ERP5TypeInformation, because factory method often do not support
       # keywords arguments.
 
-    if kw != {} : new_instance._edit(force_update=1, **kw)
-    if immediate_reindex: new_instance.immediateReindexObject()
+    if kw:
+      new_instance._edit(force_update=1, **kw)
     return new_instance
 
   security.declareProtected(