[Erp5-report] r34170 kazuhiko - /erp5/trunk/products/ERP5/Document/BusinessTemplate.py

nobody at svn.erp5.org nobody at svn.erp5.org
Fri Mar 26 22:19:42 CET 2010


Author: kazuhiko
Date: Fri Mar 26 22:19:40 2010
New Revision: 34170

URL: http://svn.erp5.org?rev=34170&view=rev
Log:
simplify the code.

Modified:
    erp5/trunk/products/ERP5/Document/BusinessTemplate.py

Modified: erp5/trunk/products/ERP5/Document/BusinessTemplate.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/BusinessTemplate.py?rev=34170&r1=34169&r2=34170&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/BusinessTemplate.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/BusinessTemplate.py [utf8] Fri Mar 26 22:19:40 2010
@@ -1984,9 +1984,9 @@
           # compare object to see it there is changes
           new_object = self._objects[path]
           old_object = installed_item._objects[path]
-          if isinstance(new_object, list) or isinstance(new_object, tuple):
+          if isinstance(new_object, (list, tuple)):
             new_object = self._chain_string_separator.join(new_object)
-          if isinstance(old_object, list) or isinstance(old_object, tuple):
+          if isinstance(old_object, (list, tuple)):
             old_object = self._chain_string_separator.join(old_object)
           if new_object != old_object:
             modified_object_list.update({path : ['Modified', self.getTemplateTypeName()]})
@@ -2366,7 +2366,7 @@
           old_value = getattr(catalog, key, None)
           if isinstance(old_value, str):
             setattr(catalog, key, method_id)
-          elif isinstance(old_value, list) or isinstance(old_value, tuple):
+          elif isinstance(old_value, (list, tuple)):
             if method_id not in old_value:
               new_value = list(old_value) + [method_id]
               new_value.sort()




More information about the Erp5-report mailing list