[Erp5-report] r33705 nicolas.dumazet - /erp5/trunk/products/ERP5Type/XMLMatrix.py

[nobody at svn.erp5.org]

Author: nicolas.dumazet
Date: Mon Mar 15 03:50:28 2010
New Revision: 33705

URL: http://svn.erp5.org?rev=33705&view=rev
Log:
add remark about limitations of consistency implementation in XMLMatrix

Modified:
    erp5/trunk/products/ERP5Type/XMLMatrix.py

Modified: erp5/trunk/products/ERP5Type/XMLMatrix.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/XMLMatrix.py?rev=33705&r1=33704&r2=33705&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/XMLMatrix.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/XMLMatrix.py [utf8] Mon Mar 15 03:50:28 2010
@@ -621,6 +621,14 @@
       if getattr(aq_base(self), 'index', None) is None:
         self.index = PersistentMapping()
       # We will check each cell of the matrix the matrix
+
+      # XXX This code assumes the following predicate:
+      #   each subobject of an XMLMatrix is either a Cell that needs
+      #   consistency checking OR ( is not a Cell, and has an id that is
+      #   not like "(\w+_)+(\d+_)*\d+" )
+      # But Documents inheriting XMLMatrix can have unrelated, non-cell
+      # subobjects, possibly with id looking like some_id_2. If it ever happens,
+      # an error will be wrongly raised.
       for obj in self.objectValues():
         object_id = obj.getId()
         # obect_id is equal to something like 'something_quantity_3_2'