[Erp5-report] r33643 nicolas - /erp5/trunk/products/ERP5Form/ProxyField.py

nobody at svn.erp5.org nobody at svn.erp5.org
Thu Mar 11 14:26:25 CET 2010


Author: nicolas
Date: Thu Mar 11 14:26:24 2010
New Revision: 33643

URL: http://svn.erp5.org?rev=33643&view=rev
Log:
I miss one optimisation here.
Use _getOb instead of getattr twice.
Thanks Julien for the tips

Modified:
    erp5/trunk/products/ERP5Form/ProxyField.py

Modified: erp5/trunk/products/ERP5Form/ProxyField.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/ProxyField.py?rev=33643&r1=33642&r2=33643&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/ProxyField.py [utf8] (original)
+++ erp5/trunk/products/ERP5Form/ProxyField.py [utf8] Thu Mar 11 14:26:24 2010
@@ -448,10 +448,8 @@
 
     if (proxy_form is not None):
       field_id = self.get_value('field_id')
-      proxy_field = getattr(aq_base(proxy_form), field_id, None)
-      if proxy_field is not None:
-        proxy_field = getattr(proxy_form, field_id)
-      else:
+      proxy_field = proxy_form._getOb(field_id, None)
+      if proxy_field is None:
         if form_id_with_skin_folder_name_flag is False:
           # Try to get the field from another field library with a lower
           # priority.




More information about the Erp5-report mailing list