[Erp5-report] r33613 nicolas.dumazet - /erp5/trunk/products/ERP5/Document/

nobody at svn.erp5.org nobody at svn.erp5.org
Thu Mar 11 06:48:18 CET 2010


Author: nicolas.dumazet
Date: Thu Mar 11 06:48:18 2010
New Revision: 33613

URL: http://svn.erp5.org?rev=33613&view=rev
Log:
use the generic XMLMatrix._updateCellRange instead of custom code

Modified:
    erp5/trunk/products/ERP5/Document/TransformedResource.py

Modified: erp5/trunk/products/ERP5/Document/TransformedResource.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/TransformedResource.py?rev=33613&r1=33612&r2=33613&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/TransformedResource.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/TransformedResource.py [utf8] Thu Mar 11 06:48:18 2010
@@ -88,20 +88,6 @@
       self.setVVariationBaseCategoryList(self.getVVariationBaseCategoryList())
 
     security.declareProtected(Permissions.ModifyPortalContent, 
-                              '_updateQMatrixCellRange')
-    def _updateQMatrixCellRange(self):
-      # XXX use base_id parameter instead
-      cell_range =  self.TransformedResource_asCellRange('quantity')
-      # XXX TransformedResource works only for a maximum of 3 variation
-      # base category...
-      # Matrixbox must be rewrite for a clean implementation of n base
-      # category
-      if len(cell_range) <= 3:
-        self.setCellRange(base_id='quantity', *cell_range)
-      else:
-        raise MoreThan3VariationBaseCategory
-
-    security.declareProtected(Permissions.ModifyPortalContent, 
                               '_setQVariationBaseCategoryList')
     def _setQVariationBaseCategoryList(self, value):
       """
@@ -109,8 +95,7 @@
         variate on
       """
       self._baseSetQVariationBaseCategoryList(value)
-      # XXX calling updatecellRange is better
-      self._updateQMatrixCellRange()
+      self._updateCellRange('quantity')
 
     security.declareProtected(Permissions.ModifyPortalContent, 
                               'setQVariationBaseCategoryList')
@@ -123,20 +108,6 @@
       self.reindexObject()
 
     security.declareProtected(Permissions.ModifyPortalContent, 
-                              '_updateVMatrixCellRange')
-    def _updateVMatrixCellRange(self):
-      # XXX use base_id parameter instead
-      cell_range =  self.TransformedResource_asCellRange('variation')
-      # XXX TransformedResource works only for a maximum of 3 variation
-      # base category...
-      # Matrixbox must be rewrite for a clean implementation of n base
-      # category
-      if len(cell_range) <= 3:
-        self.setCellRange(base_id='variation', *cell_range)
-      else:
-        raise MoreThan3VariationBaseCategory
-
-    security.declareProtected(Permissions.ModifyPortalContent, 
                               '_setVVariationBaseCategoryList')
     def _setVVariationBaseCategoryList(self, value):
       """
@@ -144,8 +115,7 @@
         variate on
       """
       self._baseSetVVariationBaseCategoryList(value)
-      # XXX calling updatecellRange is better
-      self._updateVMatrixCellRange()
+      self._updateCellRange('variation')
 
     security.declareProtected(Permissions.ModifyPortalContent, 
                               'setVVariationBaseCategoryList')




More information about the Erp5-report mailing list