[Erp5-report] r32922 jm - /erp5/trunk/products/ERP5Type/tests/testPerformance.py

[nobody at svn.erp5.org]

Author: jm
Date: Mon Feb 22 10:45:21 2010
New Revision: 32922

URL: http://svn.erp5.org?rev=32922&view=rev
Log:
Revert [32869] because there may be legitime use of TransactionalVariable for view

But add warning about use of such caches to speed view requests.

Modified:
    erp5/trunk/products/ERP5Type/tests/testPerformance.py

Modified: erp5/trunk/products/ERP5Type/tests/testPerformance.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/tests/testPerformance.py?rev=32922&r1=32921&r2=32922&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/tests/testPerformance.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/tests/testPerformance.py [utf8] Mon Feb 22 10:45:21 2010
@@ -33,7 +33,6 @@
 
 import transaction
 from DateTime import DateTime
-from Products.ERP5Type.TransactionalVariable import getTransactionalVariable
 from Products.ERP5Type.tests.ERP5TypeTestCase import ERP5TypeTestCase
 from zLOG import LOG
 from Products.ERP5Type.tests.utils import LogInterceptor
@@ -181,11 +180,15 @@
       bar.setReference(bar.getRelativeUrl())
       transaction.commit()
       self.tic()
-      tv = getTransactionalVariable(None)
       # Check performance
       before_view = time()
       for x in xrange(100):
-        tv.clear()
+        # XXX: Note that we don't clean TransactionVariable cache and REQUEST
+        #      before each call to 'view' requests. In reality, they would be
+        #      always empty at the beginning of such requests.
+        #      If you work to improve performance of 'view' requests using this
+        #      kind of cache, make sure it is actually useful outside
+        #      testPerformance.
         bar.Bar_viewPerformance()
       after_view = time()
       req_time = (after_view - before_view)/100.
@@ -244,7 +247,6 @@
       view_result = {}
       tic_result = {}
       add_result = {}
-      tv = getTransactionalVariable(None)
       # call view once to fill caches
       self.bar_module.BarModule_viewBarList()
       # add object in bar module
@@ -270,7 +272,6 @@
           gc.collect()
           before_form = time()
           for x in xrange(100):
-            tv.clear()
             self.bar_module.BarModule_viewBarList()
           after_form = time()
           # store result
@@ -333,11 +334,9 @@
                      title='Line 2')
       transaction.commit()
       self.tic()
-      tv = getTransactionalVariable(None)
       # Check performance
       before_view = time()
       for x in xrange(100):
-        tv.clear()
         foo.Foo_viewProxyField()
       after_view = time()
       req_time = (after_view - before_view)/100.
@@ -368,11 +367,9 @@
                          title='Line %s' % i)
       transaction.commit()
       self.tic()
-      tv = getTransactionalVariable(None)
       # Check performance
       before_view = time()
       for x in xrange(100):
-        tv.clear()
         foo.Foo_view()
       after_view = time()
       req_time = (after_view - before_view)/100.