[Erp5-report] r31700 nicolas.dumazet - /erp5/trunk/products/ERP5/tests/testXHTML.py

[nobody at svn.erp5.org]

Author: nicolas.dumazet
Date: Tue Jan 12 06:36:51 2010
New Revision: 31700

URL: http://svn.erp5.org?rev=31700&view=rev
Log:
str.join is much faster than successive substitutions and concatenating

Modified:
    erp5/trunk/products/ERP5/tests/testXHTML.py

Modified: erp5/trunk/products/ERP5/tests/testXHTML.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/tests/testXHTML.py?rev=31700&r1=31699&r2=31700&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/tests/testXHTML.py [utf8] (original)
+++ erp5/trunk/products/ERP5/tests/testXHTML.py [utf8] Tue Jan 12 06:36:51 2010
@@ -165,9 +165,8 @@
                                  field.get_value('field_id')))
 
     if error_list:
-      message = '\nDead proxy field list\n'
-      for error in error_list:
-        message += '\t%s\n' % str(error)
+      message = '\nDead proxy field list%s\n' \
+                    % '\n\t'.join(str(e) for e in error_list)
       self.fail(message)
 
   def test_configurationOfFieldLibrary(self):
@@ -179,9 +178,8 @@
         error_list.append((modifiable_field.object_id,
                           modifiable_field.choice_item_list[0][0]))
     if error_list:
-      message = '\nField to modify\n'
-      for error in error_list:
-        message += '\t%s\n' % str(error)
+      message = '\nField to modify%s\n' \
+                    % '\n\t'.join(str(e) for e in error_list)
       self.fail(message)
 
   def test_portalTypesDomainTranslation(self):
@@ -198,9 +196,8 @@
             error_list.append('"%s" should use erp5_ui' % \
                 portal_type.getId())
     if error_list:
-      message = '\nBad portal_type domain translation list\n'
-      for error in error_list:
-        message += '\t%s\n' % str(error)
+      message = '\nBad portal_type domain translation list%s\n' \
+                    % '\n\t'.join(error_list)
       self.fail(message)
 
   def test_emptySelectionNameInListbox(self):