[Erp5-report] r31510 nicolas.dumazet - /erp5/trunk/products/ERP5/Document/TradeCondition.py

[nobody at svn.erp5.org]

Author: nicolas.dumazet
Date: Tue Dec 29 04:18:41 2009
New Revision: 31510

URL: http://svn.erp5.org?rev=31510&view=rev
Log:
Use a set instead of a list for child_visited_trade_condition

child_visited_trade_condition_list is only used for lookups, it's faster to
rely on a set

Modified:
    erp5/trunk/products/ERP5/Document/TradeCondition.py

Modified: erp5/trunk/products/ERP5/Document/TradeCondition.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/TradeCondition.py?rev=31510&r1=31509&r2=31510&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/TradeCondition.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/TradeCondition.py [utf8] Tue Dec 29 04:18:41 2009
@@ -142,8 +142,8 @@
           # all children
           child_specialised_value_list = specialise.getSpecialiseValueList()
           # only children that match the portal_type given
-          child_visited_trade_condition_list = specialise.getSpecialiseValueList(\
-              portal_type=portal_type_list)
+          child_visited_trade_condition_set = set(specialise.\
+              getSpecialiseValueList(portal_type=portal_type_list))
         except AttributeError:
           # it is possible, that specialised object cannot be specialised
           # anymore
@@ -158,7 +158,7 @@
           if model not in intersection:
             specialise_value_list.append(model)
             # only add those who matches the portal type given
-            if model in child_visited_trade_condition_list:
+            if model in child_visited_trade_condition_set:
               visited_trade_condition_list.append(model)
 
       return visited_trade_condition_list