[Erp5-report] r31470 nicolas.dumazet - /erp5/trunk/products/ERP5/Document/

[nobody at svn.erp5.org]

Author: nicolas.dumazet
Date: Mon Dec 28 08:19:17 2009
New Revision: 31470

URL: http://svn.erp5.org?rev=31470&view=rev
Log:
Syle only: add linebreaks, save indentation to improve readability.

Modified:
    erp5/trunk/products/ERP5/Document/SimulationMovement.py

Modified: erp5/trunk/products/ERP5/Document/SimulationMovement.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/SimulationMovement.py?rev=31470&r1=31469&r2=31470&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/SimulationMovement.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/SimulationMovement.py [utf8] Mon Dec 28 08:19:17 2009
@@ -561,32 +561,36 @@
     if self.getDeliveryValue() is not None:
       # already delivered
       return False
+
     # might be buildable - business path depended
     business_path = self.getCausalityValue(portal_type='Business Path')
     explanation_value = self.getExplanationValue()
-    if business_path is not None and explanation_value is not None:
-      predecessor = business_path.getPredecessorValue()
-      if predecessor is None:
-        # first one, can be built
-        return True
-      else:
-        for successor_related in predecessor.getSuccessorRelatedValueList():
-          for business_path_movement in successor_related \
-              .getRelatedSimulationMovementValueList(explanation_value):
-            if successor_related.isMovementRelatedWithMovement(self,
-                business_path_movement):
-              business_path_movement_delivery = business_path_movement \
-                  .getDeliveryValue()
-              if business_path_movement_delivery is None:
-                return False # related movement is not delivered yet
-              business_path_movement_delivery_document = \
-                  business_path_movement_delivery.getParentValue()
-              # here we can optimise somehow, as
-              # business_path_movement_delivery_document would repeat
-              if not successor_related.isCompleted(
-                  business_path_movement_delivery_document):
-                # related movements delivery is not completed
-                return False
+
+    if business_path is None or explanation_value is None:
+      return True
+    predecessor = business_path.getPredecessorValue()
+    if predecessor is None:
+      # first one, can be built
+      return True
+
+    for successor_related in predecessor.getSuccessorRelatedValueList():
+      for business_path_movement in successor_related \
+          .getRelatedSimulationMovementValueList(explanation_value):
+        if successor_related.isMovementRelatedWithMovement(self,
+            business_path_movement):
+          business_path_movement_delivery = business_path_movement \
+              .getDeliveryValue()
+          if business_path_movement_delivery is None:
+            return False # related movement is not delivered yet
+
+          business_path_movement_delivery_document = \
+              business_path_movement_delivery.getParentValue()
+          # here we can optimise somehow, as
+          # business_path_movement_delivery_document would repeat
+          if not successor_related.isCompleted(
+              business_path_movement_delivery_document):
+            # related movements delivery is not completed
+            return False
     return True
 
   security.declareProtected( Permissions.ModifyPortalContent,