[Erp5-report] r30817 - /erp5/trunk/products/ERP5/mixin/rule.py

[nobody at svn.erp5.org]

Author: kazuhiko
Date: Mon Nov 23 16:46:05 2009
New Revision: 30817

URL: http://svn.erp5.org?rev=30817&view=rev
Log:
a little bit code optimisation.

Modified:
    erp5/trunk/products/ERP5/mixin/rule.py

Modified: erp5/trunk/products/ERP5/mixin/rule.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/mixin/rule.py?rev=30817&r1=30816&r2=30817&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/mixin/rule.py [utf8] (original)
+++ erp5/trunk/products/ERP5/mixin/rule.py [utf8] Mon Nov 23 16:46:05 2009
@@ -312,7 +312,8 @@
     # First, we update all properties (exc. quantity) which could be divergent
     # and if we can not, we compensate them
     for decision_movement in decision_movement_list:
-      decision_quantity += decision_movement.getQuantity()
+      decision_movement_quantity = decision_movement.getQuantity()
+      decision_quantity += decision_movement_quantity
       if self._isProfitAndLossMovement(decision_movement):
         if decision_movement.isFrozen():
           # Record not completed movements
@@ -320,9 +321,9 @@
             not_completed_movement = decision_movement
           # Frozen must be compensated
           if not _compare(profit_tester_list, prevision_movement, decision_movement):
-            new_movement = decision_movement.asContext(quantity=-decision_movement.getQuantity())
+            new_movement = decision_movement.asContext(quantity=-decision_movement_quantity)
             movement_collection_diff.addNewMovement(new_movement)
-            compensated_quantity += decision_movement.getQuantity()
+            compensated_quantity += decision_movement_quantity
         else:
           updatable_compensation_movement = decision_movement
           # Not Frozen can be updated
@@ -336,9 +337,9 @@
         if decision_movement.isFrozen():
           # Frozen must be compensated
           if not _compare(divergence_tester_list, prevision_movement, decision_movement):
-            new_movement = decision_movement.asContext(quantity=-decision_movement.getQuantity())
+            new_movement = decision_movement.asContext(quantity=-decision_movement_quantity)
             movement_collection_diff.addNewMovement(new_movement)
-            compensated_quantity += decision_movement.getQuantity()
+            compensated_quantity += decision_movement_quantity
         else:
           updatable_movement = decision_movement
           # Not Frozen can be updated