[Erp5-report] r30624 - /erp5/trunk/products/ERP5Type/interfaces/divergence_message.py

[nobody at svn.erp5.org]

Author: jp
Date: Sun Nov 15 10:11:39 2009
New Revision: 30624

URL: http://svn.erp5.org?rev=30624&view=rev
Log:
Added commens to explain how refactoring must be handled.

Modified:
    erp5/trunk/products/ERP5Type/interfaces/divergence_message.py

Modified: erp5/trunk/products/ERP5Type/interfaces/divergence_message.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/interfaces/divergence_message.py?rev=30624&r1=30623&r2=30624&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/interfaces/divergence_message.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/interfaces/divergence_message.py [utf8] Sun Nov 15 10:11:39 2009
@@ -33,7 +33,19 @@
 
 class IDivergenceMessage(Interface):
   def getMovementGroup():
-    """Returns movement group of a builder which was responsible for generating tested_property"""
+    """Returns movement group of a builder which was
+    responsible for generating tested_property.
+
+    XXX-JPS - REFACTOR NEEDED
+
+    Issue 1:
+      This is wrong since multiple builders can be used to 
+      build a single Delivery. Moreover, what is used for grouping
+      and what is used to set properties can be different.
+
+    Issue 2:
+      This class is related to ERP5 and not to ERP5Type
+    """
 
   def getCollectOrderGroup():
     """Wraps and canonises result of Movement Groups' getCollectOrderGroup getter"""