[Erp5-report] r30101 - /erp5/trunk/products/ERP5Type/tests/runUnitTest.py

[nobody at svn.erp5.org]

Author: nicolas.dumazet
Date: Thu Oct 29 11:55:24 2009
New Revision: 30101

URL: http://svn.erp5.org?rev=30101&view=rev
Log:
* Compile the regexes once and only once: at initialization.
* rename test_patterns_list in test_pattern_list
* do not create the attribute unless it's meaningful

Modified:
    erp5/trunk/products/ERP5Type/tests/runUnitTest.py

Modified: erp5/trunk/products/ERP5Type/tests/runUnitTest.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/tests/runUnitTest.py?rev=30101&r1=30100&r2=30101&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/tests/runUnitTest.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/tests/runUnitTest.py [utf8] Thu Oct 29 11:55:24 2009
@@ -190,9 +190,10 @@
 class ERP5TypeTestLoader(unittest.TestLoader):
   """Load test cases from the name passed on the command line.
   """
-  def __init__(self, test_patterns_list=None):
+  def __init__(self, test_pattern_list=None):
     super(ERP5TypeTestLoader, self).__init__()
-    self.test_patterns_list = test_patterns_list
+    if test_pattern_list is not None:
+      self.test_pattern_list = map(re.compile, test_pattern_list)
 
   def loadTestsFromName(self, name, module=None):
     """This method is here for compatibility with old style arguments.
@@ -223,8 +224,8 @@
     for item in test_list:
       if isinstance(item, unittest.TestCase):
         test_method_name = item.id().rsplit('.', 1)[-1]
-        for valid_test_method_name_re in self.test_patterns_list:
-          if re.search(valid_test_method_name_re, test_method_name):
+        for valid_test_method_name_re in self.test_pattern_list:
+          if valid_test_method_name_re.search(test_method_name):
             filtered.append(item)
       elif isinstance(item, FilteredTestSuite):
         # has already been filtered, dont check it again
@@ -240,7 +241,7 @@
   def suiteClass(self, test_list):
     """Constructs a Test Suite from test lists.
     Keep only tests matching commandline parameter --run_only"""
-    if self.test_patterns_list:
+    if hasattr(self, 'test_pattern_list'):
       test_list = self._filterTestList(test_list)
 
     return FilteredTestSuite(test_list)