[Erp5-report] r27286 - /erp5/trunk/products/ERP5/Document/TradeCondition.py

[nobody at svn.erp5.org]

Author: jp
Date: Mon Jun  1 11:46:22 2009
New Revision: 27286

URL: http://svn.erp5.org?rev=27286&view=rev
Log:
Added some comments on the current implemntation which is too simple. Integration of paysheet model to Trade Condition code will reveal this issue and others.

Modified:
    erp5/trunk/products/ERP5/Document/TradeCondition.py

Modified: erp5/trunk/products/ERP5/Document/TradeCondition.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/TradeCondition.py?rev=27286&r1=27285&r2=27286&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/TradeCondition.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/TradeCondition.py [utf8] Mon Jun  1 11:46:22 2009
@@ -114,10 +114,14 @@
               'movement_to_add_list': movement_to_add_list}
 
     def getTradeModelLineComposedList(self, context=None):
-      """Returns list of Trade Model Lines using composition
+      """
+      Returns list of Trade Model Lines using composition
       Resource of Trade Model Line is used to hide other Trade Model Line
+        XXX - wrong - use reference to hide
       In chain first found Trade Model Line has precedence
-      Context's, if not None, Trade Model Lines have precedence"""
+      Context's, if not None, Trade Model Lines have precedence
+        XXX - the sorting is missing
+      """
       visited_trade_condition_list = []
       def findSpecialiseValueList(context):
         specialise_value_list = []
@@ -163,8 +167,8 @@
         need_to_run = 0
         for model_line in trade_model_line_composed_list:
           model_line_result = model_line.getAggregatedAmountList(context,
-            movement_list = movement_list,
-            current_aggregated_amount_list = result,
+            movement_list=movement_list,
+            current_aggregated_amount_list=result,
             **kw)
           result.extend(model_line_result)
         if len(result) != len(movement_list):