[Erp5-report] r27119 - /erp5/trunk/products/ERP5Type/DocumentationHelper/

nobody at svn.erp5.org nobody at svn.erp5.org
Fri May 22 15:55:49 CEST 2009


Author: jp
Date: Fri May 22 15:55:46 2009
New Revision: 27119

URL: http://svn.erp5.org?rev=27119&view=rev
Log:
Use accessors and do not hide errors

Modified:
    erp5/trunk/products/ERP5Type/DocumentationHelper/DCWorkflowTransitionDocumentationHelper.py

Modified: erp5/trunk/products/ERP5Type/DocumentationHelper/DCWorkflowTransitionDocumentationHelper.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/DocumentationHelper/DCWorkflowTransitionDocumentationHelper.py?rev=27119&r1=27118&r2=27119&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/DocumentationHelper/DCWorkflowTransitionDocumentationHelper.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/DocumentationHelper/DCWorkflowTransitionDocumentationHelper.py [utf8] Fri May 22 15:55:46 2009
@@ -50,8 +50,7 @@
     """
     Returns the title of the documentation helper
     """
-    return DocumentationHelper.getTitle(self) \
-        or self.getDocumentedObject().actbox_name
+    return DocumentationHelper.getTitle(self) or getattr(self.getDocumentedObject(), 'actbox_name')
 
   security.declareProtected(Permissions.AccessContentsInformation, 'getNewState')
   def getNewState(self):
@@ -61,6 +60,7 @@
     if new_state_id:
       uri = '%s/states/%s' % (self.uri.rsplit('/',2)[0], new_state_id)
       return self.getDocumentationHelper('DCWorkflowStateDocumentationHelper', uri)
+	
 
   security.declareProtected(Permissions.AccessContentsInformation, 'getTriggerType')
   def getTriggerType(self):
@@ -68,7 +68,7 @@
     Returns the trigger type for de workflow transition
     """
     trigger_type_list = ['Automatic','Initiated by user action','Initiated by WorkflowMethod']
-    trigger_type_id = getattr(self.getDocumentedObject(), "trigger_type", '')
+    trigger_type_id = getattr(self.getDocumentedObject(), "trigger_type")
     return trigger_type_list[trigger_type_id]
 
   security.declareProtected(Permissions.AccessContentsInformation, 'getScriptName')
@@ -76,14 +76,14 @@
     """
     Returns the name of the script for de workflow transition
     """
-    return getattr(self.getDocumentedObject(), "script_name", '')
+    return getattr(self.getDocumentedObject(), "script_name")
 
   security.declareProtected(Permissions.AccessContentsInformation, 'getAfterScriptName')
   def getAfterScriptName(self):
     """
     Returns the name of the script for de workflow transition
     """
-    return getattr(self.getDocumentedObject(), "after_script_name", '')
+    return getattr(self.getDocumentedObject(), "after_script_name")
 
   security.declareProtected(Permissions.AccessContentsInformation, 'getRoleColumnList')
   def getRoleColumnList(self):




More information about the Erp5-report mailing list