[Erp5-report] r27099 - in /erp5/trunk/products/ZSQLCatalog: ./ Interface/ SearchKey/

[nobody at svn.erp5.org]

Author: vincent
Date: Fri May 22 15:12:29 2009
New Revision: 27099

URL: http://svn.erp5.org?rev=27099&view=rev
Log:
Replace a (currently) un-fixable log by an XXX comment in code.
Remove deprecated method from API.
Update method caller to use private method instead, while advertising that it must be fixed when technical alternative is implemented.

Modified:
    erp5/trunk/products/ZSQLCatalog/ColumnMap.py
    erp5/trunk/products/ZSQLCatalog/Interface/IColumnMap.py
    erp5/trunk/products/ZSQLCatalog/SearchKey/RelatedKey.py

Modified: erp5/trunk/products/ZSQLCatalog/ColumnMap.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/ColumnMap.py?rev=27099&r1=27098&r2=27099&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/ColumnMap.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/ColumnMap.py [utf8] Fri May 22 15:12:29 2009
@@ -474,10 +474,6 @@
   def _addJoinQuery(self, query):
     self.join_query_list.append(query)
 
-  def addJoinQuery(self, query):
-    LOG('ColumnMap', INFO, 'addJoinQuery use is discouraged')
-    self._addJoinQuery(query)
-
   def iterJoinQueryList(self):
     return iter(self.join_query_list)
 

Modified: erp5/trunk/products/ZSQLCatalog/Interface/IColumnMap.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/Interface/IColumnMap.py?rev=27099&r1=27098&r2=27099&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/Interface/IColumnMap.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/Interface/IColumnMap.py [utf8] Fri May 22 15:12:29 2009
@@ -271,13 +271,6 @@
         Group id of given table.
     """
 
-  def addJoinQuery(query):
-    """
-      Adds a query to a list of top-level queries.
-      This method is only made available at interface level for backward
-      compatibility.
-    """
-
   def iterJoinQueryList():
     """
       Get an iterator over queries internally generated when resolving column

Modified: erp5/trunk/products/ZSQLCatalog/SearchKey/RelatedKey.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SearchKey/RelatedKey.py?rev=27099&r1=27098&r2=27099&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SearchKey/RelatedKey.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/SearchKey/RelatedKey.py [utf8] Fri May 22 15:12:29 2009
@@ -190,7 +190,10 @@
     # Note that doing this has a side effect on result list, as objects
     # lacking a relation will never appear in the result.
     if BACKWARD_COMPATIBILITY:
-      column_map.addJoinQuery(SQLQuery(rendered_related_key))
+      # XXX: Calling a private-ish method on column_map.
+      # This should never happen. It should be removed as soon as an
+      # alternative exists.
+      column_map._addJoinQuery(SQLQuery(rendered_related_key))
       return None
     else:
       return SQLExpression(self, where_expression=rendered_related_key)