[Erp5-report] r26882 - /erp5/trunk/products/ERP5/Document/TradeModelRule.py

[nobody at svn.erp5.org]

Author: luke
Date: Thu May  7 17:44:02 2009
New Revision: 26882

URL: http://svn.erp5.org?rev=26882&view=rev
Log:
 - move setting static property dict to method, easier to class method for re usability

Modified:
    erp5/trunk/products/ERP5/Document/TradeModelRule.py

Modified: erp5/trunk/products/ERP5/Document/TradeModelRule.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/TradeModelRule.py?rev=26882&r1=26881&r2=26882&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/TradeModelRule.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/TradeModelRule.py [utf8] Thu May  7 17:44:02 2009
@@ -106,6 +106,12 @@
 
     return movement_dict
 
+  def _getStaticPropertyDict(self, context_movement):
+    movement_kw = {}
+    for prop in self.getExpandablePropertyList():
+      movement_kw[prop] = context_movement.getProperty(prop)
+    return movement_kw
+
   def _generatePrevisionList(self, applied_rule, **kw):
     """Generates list of movements (as dicts), and let parent class to decide
     which is to add, modify or delete"""
@@ -118,10 +124,8 @@
 
     for amount in trade_condition.getAggregatedAmountList(applied_rule):
       context_movement = applied_rule.getParentValue()
-      movement_kw = {}
       # everything static
-      for prop in self.getExpandablePropertyList():
-        movement_kw[prop] = context_movement.getProperty(prop)
+      movement_kw = self._getStaticPropertyDict(context_movement)
 
       # business path specific
       business_path_list = business_process.getPathValueList(