[Erp5-report] r26641 - in /erp5/trunk/products/ERP5/bootstrap/erp5_core: SkinTemplateItem/p...

nobody at svn.erp5.org nobody at svn.erp5.org
Mon Apr 27 09:37:39 CEST 2009


Author: kazuhiko
Date: Mon Apr 27 09:37:39 2009
New Revision: 26641

URL: http://svn.erp5.org?rev=26641&view=rev
Log:
We need to make a 'shallow copy' here other wise the cached value is also modified.
(bad)
  tmp_list = caching_method()
  tmp_list.extend(...)
(good)
  tmp_list = caching_method()[:]
  tmp_list.extend(...)

Modified:
    erp5/trunk/products/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Predicate_getMembershipCriterionCategoryList.xml
    erp5/trunk/products/ERP5/bootstrap/erp5_core/bt/revision

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Predicate_getMembershipCriterionCategoryList.xml
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Predicate_getMembershipCriterionCategoryList.xml?rev=26641&r1=26640&r2=26641&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Predicate_getMembershipCriterionCategoryList.xml [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Predicate_getMembershipCriterionCategoryList.xml [utf8] Mon Apr 27 09:37:39 2009
@@ -66,7 +66,7 @@
 ctool = context.portal_categories\n
 for item in mixed_list:\n
   base_category = ctool[item]\n
-  item_list = base_category.getCategoryChildCompactLogicalPathItemList(base=1)\n
+  item_list = base_category.getCategoryChildCompactLogicalPathItemList(base=1)[:]\n
   if item_list == [[\'\', \'\']]:\n
     for fallback_category in base_category.getFallbackBaseCategoryList():\n
       fallback_category = ctool.restrictedTraverse(fallback_category, None)\n

Modified: erp5/trunk/products/ERP5/bootstrap/erp5_core/bt/revision
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/bootstrap/erp5_core/bt/revision?rev=26641&r1=26640&r2=26641&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/bootstrap/erp5_core/bt/revision [utf8] (original)
+++ erp5/trunk/products/ERP5/bootstrap/erp5_core/bt/revision [utf8] Mon Apr 27 09:37:39 2009
@@ -1,1 +1,1 @@
-1168
+1169




More information about the Erp5-report mailing list