[Erp5-report] r26139 - in /erp5/trunk/products/ZSQLCatalog: ./ Operator/

[nobody at svn.erp5.org]

Author: vincent
Date: Tue Mar 24 12:41:17 2009
New Revision: 26139

URL: http://svn.erp5.org?rev=26139&view=rev
Log:
Implement select expression merge in a column-name-independent way.

Modified:
    erp5/trunk/products/ZSQLCatalog/Operator/ComparisonOperator.py
    erp5/trunk/products/ZSQLCatalog/SQLExpression.py

Modified: erp5/trunk/products/ZSQLCatalog/Operator/ComparisonOperator.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/Operator/ComparisonOperator.py?rev=26139&r1=26138&r2=26139&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/Operator/ComparisonOperator.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/Operator/ComparisonOperator.py [utf8] Tue Mar 24 12:41:17 2009
@@ -126,6 +126,7 @@
       select_dict=select_dict,
       where_expression=match_string,
       order_by_dict=order_by_dict,
+      can_merge_select_dict=True,
     )
 
 verifyClass(IOperator, MatchComparisonOperator)

Modified: erp5/trunk/products/ZSQLCatalog/SQLExpression.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SQLExpression.py?rev=26139&r1=26138&r2=26139&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SQLExpression.py [utf8] (original)
+++ erp5/trunk/products/ZSQLCatalog/SQLExpression.py [utf8] Tue Mar 24 12:41:17 2009
@@ -70,13 +70,15 @@
                sql_expression_list=(),
                select_dict=None,
                limit=None,
-               from_expression=None):
+               from_expression=None,
+               can_merge_select_dict=False):
     if DEBUG:
       self.query = query
     self.table_alias_dict = defaultDict(table_alias_dict)
     self.order_by_list = list(order_by_list)
     self.group_by_list = list(group_by_list)
     self.order_by_dict = defaultDict(order_by_dict)
+    self.can_merge_select_dict = can_merge_select_dict
     # Only one of (where_expression, where_expression_operator) must be given (never both)
     assert None in (where_expression, where_expression_operator)
     # Exactly one of (where_expression, where_expression_operator) must be given, except if sql_expression_list is given and contains exactly one entry
@@ -283,26 +285,28 @@
     """
     return SQL_LIST_SEPARATOR.join(self.getGroupByset())
 
-  @profiler_decorator
-  def getSelectDict(self):
-    """
-      Returns a dict:
-        key: alias (string)
-        value: column (string) or None
-
-      If there are nested SQLExpression, it aggregates their mappings and
-      checks that they don't alias different columns with the same name. If
-      they do, it raises a ValueError.
-    """
+  def canMergeSelectDict(self):
+    return self.can_merge_select_dict
+
+  @profiler_decorator
+  def _getSelectDict(self):
     result = self.select_dict.copy()
-    for sql_expression in self.sql_expression_list:
-      for alias, column in sql_expression.getSelectDict().iteritems():
+    mergeable_set = set()
+    if self.canMergeSelectDict():
+      mergeable_set.update(result)
+    for sql_expression in self.sql_expression_list:
+      can_merge_sql_expression = sql_expression.canMergeSelectDict()
+      sql_expression_select_dict, sql_expression_mergeable_set = \
+        sql_expression._getSelectDict()
+      mergeable_set.update(sql_expression_mergeable_set)
+      for alias, column in sql_expression_select_dict.iteritems():
         existing_value = result.get(alias)
         if existing_value not in (None, column):
-          if alias == 'SearchableText':
+          if can_merge_sql_expression and alias in mergeable_set:
             # Custom conflict resolution
             column = '%s + %s' % (existing_value, column)
           else:
+            import pdb; pdb.set_trace()
             message = '%r is a known alias for column %r, can\'t alias it now to column %r' % (alias, existing_value, column)
             if DEBUG:
               message = message + '. I was created by %r, and I am working on %r (%r) out of [%s]' % (
@@ -311,8 +315,23 @@
                 sql_expression.query,
                 ', '.join('%r (%r)' % (x, x.query) for x in self.sql_expression_list))
             raise ValueError, message
-        result[alias] = column
-    return result
+        result[alias] = (column, can_merge_sql_expression)
+        if can_merge_sql_expression:
+          mergeable_set.add(alias)
+    return result, mergeable_set
+
+  @profiler_decorator
+  def getSelectDict(self):
+    """
+      Returns a dict:
+        key: alias (string)
+        value: column (string) or None
+
+      If there are nested SQLExpression, it aggregates their mappings and
+      checks that they don't alias different columns with the same name. If
+      they do, it raises a ValueError.
+    """
+    return self._getSelectDict()[0]
 
   @profiler_decorator
   def getSelectExpression(self):