[Erp5-report] r24942 - /erp5/trunk/products/ERP5OOo/OOoTemplate.py

nobody at svn.erp5.org nobody at svn.erp5.org
Thu Dec 18 18:29:33 CET 2008


Author: jerome
Date: Thu Dec 18 18:29:32 2008
New Revision: 24942

URL: http://svn.erp5.org?rev=24942&view=rev
Log:
content disposition needs "" arround filename to support spaces in the filename

Modified:
    erp5/trunk/products/ERP5OOo/OOoTemplate.py

Modified: erp5/trunk/products/ERP5OOo/OOoTemplate.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5OOo/OOoTemplate.py?rev=24942&r1=24941&r2=24942&view=diff
==============================================================================
--- erp5/trunk/products/ERP5OOo/OOoTemplate.py [utf8] (original)
+++ erp5/trunk/products/ERP5OOo/OOoTemplate.py [utf8] Thu Dec 18 18:29:32 2008
@@ -522,7 +522,7 @@
 
     if not format and not batch_mode:
       request.RESPONSE.setHeader('Content-Type','%s; charset=utf-8' % self.content_type)
-      request.RESPONSE.setHeader('Content-disposition', 'inline;filename=%s' % self.title_or_id())
+      request.RESPONSE.setHeader('Content-disposition', 'inline;filename="%s"' % self.title_or_id())
     
     if DevelopmentMode:
       # Validate XML in development mode
@@ -568,22 +568,26 @@
               if x[1].endswith('pdf')]
       if len(tgts) > 1:
         REQUEST.RESPONSE.setHeader('Content-type', 'text/html')
-        REQUEST.RESPONSE.setHeader('Content-disposition', 'inline;filename=%s.pdf' % self.title_or_id())
+        REQUEST.RESPONSE.setHeader('Content-disposition',
+            'inline;filename="%s.pdf"' % self.title_or_id())
         raise ValueError, 'multiple pdf formats found - this shouldnt happen'
       if len(tgts) == 0:
         REQUEST.RESPONSE.setHeader('Content-type', 'text/html')
-        REQUEST.RESPONSE.setHeader('Content-disposition', 'inline;filename=%s.pdf' % self.title_or_id())    
+        REQUEST.RESPONSE.setHeader('Content-disposition',
+            'inline;filename="%s.pdf"' % self.title_or_id())
         raise ValueError, 'no pdf format found'
       fmt = tgts[0]
       mime, data = tmp_ooo.convert(fmt)
       if REQUEST is not None:
           REQUEST.RESPONSE.setHeader('Content-type', 'application/pdf')
-          REQUEST.RESPONSE.setHeader('Content-disposition', 'attachment;filename=%s.pdf' % self.title_or_id())
+          REQUEST.RESPONSE.setHeader('Content-disposition',
+              'attachment;filename="%s.pdf"' % self.title_or_id())
       return data
     mime, data = tmp_ooo.convert(format)
     if REQUEST is not None and not batch_mode:
       REQUEST.RESPONSE.setHeader('Content-type', mime)
-      REQUEST.RESPONSE.setHeader('Content-disposition', 'attachment;filename=%s.%s' % (self.title_or_id(),format))
+      REQUEST.RESPONSE.setHeader('Content-disposition',
+          'attachment;filename="%s.%s"' % (self.title_or_id(),format))
         # FIXME the above lines should return zip format when html was requested
     return data
 




More information about the Erp5-report mailing list