[Erp5-report] r24582 - /erp5/trunk/products/ERP5/Document/OrderBuilder.py

[nobody at svn.erp5.org]

Author: kazuhiko
Date: Thu Nov 13 13:51:09 2008
New Revision: 24582

URL: http://svn.erp5.org?rev=24582&view=rev
Log:
fix a bug that bogus variation category can be left for created lines.
add a comment for further improvement.

Modified:
    erp5/trunk/products/ERP5/Document/OrderBuilder.py

Modified: erp5/trunk/products/ERP5/Document/OrderBuilder.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5/Document/OrderBuilder.py?rev=24582&r1=24581&r2=24582&view=diff
==============================================================================
--- erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] (original)
+++ erp5/trunk/products/ERP5/Document/OrderBuilder.py [utf8] Thu Nov 13 13:51:09 2008
@@ -470,6 +470,8 @@
             parent._duplicate(parent.manage_copyObjects(ids=ids))[0],
             (delivery, old_delivery_line.getId()), {}, CopyError)
           delivery_line = delivery[cp['new_id']]
+          # reset variation category list
+          delivery_line.setVariationCategoryList([])
           # delete non-split movements
           keep_id_list = [y.getDeliveryValue().getId() for y in \
                           movement_group.getMovementList()]
@@ -482,6 +484,8 @@
         delivery_line.edit(**property_dict)
 
       # Update variation category list on line
+      # XXX updating variation category list should be also handled by
+      # MovementGroup
       line_variation_category_list = delivery_line.getVariationCategoryList()
       for movement in movement_group.getMovementList():
         line_variation_category_list.extend(