[Erp5-report] r22984 - /erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

[nobody at svn.erp5.org]

Author: vincent
Date: Wed Aug 13 17:18:33 2008
New Revision: 22984

URL: http://svn.erp5.org?rev=22984&view=rev
Log:
Add a warning about ambiguous code (loop must only be executed once for code to work).

Modified:
    erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

Modified: erp5/trunk/products/ZSQLCatalog/SQLCatalog.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SQLCatalog.py?rev=22984&r1=22983&r2=22984&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SQLCatalog.py (original)
+++ erp5/trunk/products/ZSQLCatalog/SQLCatalog.py Wed Aug 13 17:18:33 2008
@@ -1833,6 +1833,7 @@
           if hasattr(current_query, 'order_by'): query_group_by_list = current_query.order_by
         else:
           if isinstance(value, dict):
+            # XXX: If dictionary has more that one key, subsequent Query() will raise.
             for value_key in value.keys():
               if value_key == 'query':
                 new_query_dict[key] = value['query']