[Erp5-report] r22593 - in /erp5/trunk/bt5/erp5_banking_core: WorkflowTemplateItem/portal_wo...

nobody at svn.erp5.org nobody at svn.erp5.org
Mon Jul 21 14:44:57 CEST 2008


Author: vincent
Date: Mon Jul 21 14:44:56 2008
New Revision: 22593

URL: http://svn.erp5.org?rev=22593&view=rev
Log:
Do not use id as a catalog search criterion. It's a performance crime.

Modified:
    erp5/trunk/bt5/erp5_banking_core/WorkflowTemplateItem/portal_workflow/counter_date_workflow/scripts/openAllCounter.xml
    erp5/trunk/bt5/erp5_banking_core/bt/revision

Modified: erp5/trunk/bt5/erp5_banking_core/WorkflowTemplateItem/portal_workflow/counter_date_workflow/scripts/openAllCounter.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_banking_core/WorkflowTemplateItem/portal_workflow/counter_date_workflow/scripts/openAllCounter.xml?rev=22593&r1=22592&r2=22593&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_banking_core/WorkflowTemplateItem/portal_workflow/counter_date_workflow/scripts/openAllCounter.xml (original)
+++ erp5/trunk/bt5/erp5_banking_core/WorkflowTemplateItem/portal_workflow/counter_date_workflow/scripts/openAllCounter.xml Mon Jul 21 14:44:56 2008
@@ -105,12 +105,8 @@
 \n
 \n
 # Set a reference\n
-site_id = counter_date.getSiteId()\n
-if site_id is None:\n
-  msg = Message(domain=\'ui\',message="You must define the site")\n
-  raise ValidationFailed (msg,)\n
 counter_date_list = [x.getObject() for x  in context.portal_catalog(\n
-                                           portal_type=\'Counter Date\',site_id=site_id,\n
+                                           portal_type=\'Counter Date\',site_uid=site_uid,\n
                                            sort_on=[(\'start_date\',\'descending\')],limit=1,\n
                                            simulation_state=(\'open\',\'closed\'))]\n
 previous_reference = None\n
@@ -193,7 +189,6 @@
                             <string>line</string>
                             <string>context</string>
                             <string>counter</string>
-                            <string>site_id</string>
                             <string>previous_reference</string>
                             <string>len</string>
                             <string>previous_counter_date</string>

Modified: erp5/trunk/bt5/erp5_banking_core/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_banking_core/bt/revision?rev=22593&r1=22592&r2=22593&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_banking_core/bt/revision (original)
+++ erp5/trunk/bt5/erp5_banking_core/bt/revision Mon Jul 21 14:44:56 2008
@@ -1,1 +1,1 @@
-442
+445




More information about the Erp5-report mailing list