[Erp5-report] r22399 - /erp5/trunk/products/ERP5Wizard/Tool/WizardTool.py

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Jul 9 17:26:39 CEST 2008


Author: jerome
Date: Wed Jul  9 17:26:38 2008
New Revision: 22399

URL: http://svn.erp5.org?rev=22399&view=rev
Log:
rename _getServerInfo in _updateParameterDictWithServerInfo, because it's
updating the dict in place, and not returning anything, as the _get prefix
would make think

Modified:
    erp5/trunk/products/ERP5Wizard/Tool/WizardTool.py

Modified: erp5/trunk/products/ERP5Wizard/Tool/WizardTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Wizard/Tool/WizardTool.py?rev=22399&r1=22398&r2=22399&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Wizard/Tool/WizardTool.py (original)
+++ erp5/trunk/products/ERP5Wizard/Tool/WizardTool.py Wed Jul  9 17:26:38 2008
@@ -305,7 +305,7 @@
     witch_tool = self._getRemoteWitchTool(server_url)
     parameter_dict = self.REQUEST.form
     ## add client arguments
-    self._getServerInfo(parameter_dict)
+    self._updateParameterDictWithServerInfo(parameter_dict)
     ## call remote method 
     try:
       method = getattr(witch_tool, distant_method)     
@@ -349,9 +349,9 @@
         self.setExpressConfigurationPreference(_server_to_preference_ids_map[item],
                                                value)
       
-  def _getServerInfo(self, parameter_dict):
-    """ Return local saved server info settings. """
-    global _server_to_preference_ids_map 
+  def _updateParameterDictWithServerInfo(self, parameter_dict):
+    """Updates parameter_dict to include local saved server info settings. """
+    global _server_to_preference_ids_map
     for key, value in _server_to_preference_ids_map.items():
       parameter_dict[key] = self.getExpressConfigurationPreference(value, None)
     #for key, value in _v_server_buffer.items():




More information about the Erp5-report mailing list