[Erp5-report] r22032 - /erp5/trunk/products/CMFCategory/CategoryTool.py
nobody at svn.erp5.org
nobody at svn.erp5.org
Fri Jun 27 13:56:23 CEST 2008
Author: vincent
Date: Fri Jun 27 13:56:17 2008
New Revision: 22032
URL: http://svn.erp5.org?rev=22032&view=rev
Log:
Remove broken code: calling "+=" operator on a list object with a string as right operand never generates valid SQL.
Modified:
erp5/trunk/products/CMFCategory/CategoryTool.py
Modified: erp5/trunk/products/CMFCategory/CategoryTool.py
URL: http://svn.erp5.org/erp5/trunk/products/CMFCategory/CategoryTool.py?rev=22032&r1=22031&r2=22032&view=diff
==============================================================================
--- erp5/trunk/products/CMFCategory/CategoryTool.py (original)
+++ erp5/trunk/products/CMFCategory/CategoryTool.py Fri Jun 27 13:56:17 2008
@@ -1467,27 +1467,6 @@
else:
expression += ' AND %s.base_category_uid = %s' % (query_table,base_category_uid)
sql_expr += ["(%s)" % expression]
- else:
- single_sql_expr = []
- for single_category in category:
- if single_sql_expr != '':
- category_uid = self.getCategoryUid(single_category)
- base_category_uid = self.getBaseCategoryUid(single_category)
- if none_sql_value is not None and category_uid is None:
- category_uid = none_sql_value
- if category_uid is None:
- expression += '%s.category_uid is NULL' % query_table
- else:
- expression += '%s.category_uid = %s' % (query_table,category_uid)
- if none_sql_value is not None and base_category_uid is None:
- base_category_uid = none_sql_value
- if base_category_uid is None:
- expression += ' AND %s.base_category_uid is NULL' % query_table
- else:
- expression += ' AND %s.base_category_uid = %s' % (query_table,base_category_uid)
- single_sql_expr += ["(%s)" % expression]
- if len(single_sql_expr) > 0:
- sql_expr += "( %s )" % ' OR '.join(single_sql_expr)
if len(sql_expr) > 0:
sql_expr = ' OR '.join(sql_expr)
return sql_expr
More information about the Erp5-report
mailing list