[Erp5-report] r20359 - /erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

nobody at svn.erp5.org nobody at svn.erp5.org
Tue Apr 8 16:59:44 CEST 2008


Author: yo
Date: Tue Apr  8 16:59:43 2008
New Revision: 20359

URL: http://svn.erp5.org?rev=20359&view=rev
Log:
As discussed with seb, it should not be required to add portal_type here, because here.getPortalType() must work. Add some comment on the purpose of having some hardcoded items. 

Modified:
    erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

Modified: erp5/trunk/products/ZSQLCatalog/SQLCatalog.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SQLCatalog.py?rev=20359&r1=20358&r2=20359&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SQLCatalog.py (original)
+++ erp5/trunk/products/ZSQLCatalog/SQLCatalog.py Tue Apr  8 16:59:43 2008
@@ -2354,13 +2354,15 @@
             #'request':      getattr( ob, 'REQUEST', None ),
             #'modules':      SecureModuleImporter,
             #'user':         getSecurityManager().getUser(),
-            'isDelivery':   ob.isDelivery, # XXX
-            'isMovement':   ob.isMovement, # XXX
-            'isPredicate':  ob.isPredicate, # XXX
-            'isDocument':   ob.isDocument, # XXX
-            'isInventory':  ob.isInventory, # XXX
-            'portal_type':  ob.portal_type, # XXX
-            'isInventoryMovement': ob.isInventoryMovement, # XXX
+            # XXX these below are defined, because there is no
+            # accessor for some attributes, and restricted environment
+            # may not access them directly.
+            'isDelivery':   ob.isDelivery,
+            'isMovement':   ob.isMovement,
+            'isPredicate':  ob.isPredicate,
+            'isDocument':   ob.isDocument,
+            'isInventory':  ob.isInventory,
+            'isInventoryMovement': ob.isInventoryMovement,
             }
         return getEngine().getContext(data)
 




More information about the Erp5-report mailing list