[Erp5-report] r19265 - /erp5/trunk/products/CMFActivity/ActivityTool.py

nobody at svn.erp5.org nobody at svn.erp5.org
Tue Feb 12 11:32:58 CET 2008


Author: vincent
Date: Tue Feb 12 11:32:57 2008
New Revision: 19265

URL: http://svn.erp5.org?rev=19265&view=rev
Log:
Remove unneeded "global" statements.
Add a comment about "assert" statement.

Modified:
    erp5/trunk/products/CMFActivity/ActivityTool.py

Modified: erp5/trunk/products/CMFActivity/ActivityTool.py
URL: http://svn.erp5.org/erp5/trunk/products/CMFActivity/ActivityTool.py?rev=19265&r1=19264&r2=19265&view=diff
==============================================================================
--- erp5/trunk/products/CMFActivity/ActivityTool.py (original)
+++ erp5/trunk/products/CMFActivity/ActivityTool.py Tue Feb 12 11:32:57 2008
@@ -706,8 +706,8 @@
            can be only one access at a time to a key
          - GIL protects us when accessing python instances
       """
-      global global_activity_buffer
-      global global_activity_buffer_lock
+      # Safeguard: make sure we are wrapped in  acquisition context before
+      # using our path as an activity tool instance-wide identifier.
       assert getattr(self, 'aq_self', None) is not None
       my_instance_key = self.getPhysicalPath()
       my_thread_key = get_ident()




More information about the Erp5-report mailing list