[Erp5-report] r19263 - /erp5/trunk/products/CMFActivity/ActivityTool.py

[nobody at svn.erp5.org]

Author: vincent
Date: Tue Feb 12 10:33:47 2008
New Revision: 19263

URL: http://svn.erp5.org?rev=19263&view=rev
Log:
Call sys.exc_info() just once in Message.__call__ error path.

Modified:
    erp5/trunk/products/CMFActivity/ActivityTool.py

Modified: erp5/trunk/products/CMFActivity/ActivityTool.py
URL: http://svn.erp5.org/erp5/trunk/products/CMFActivity/ActivityTool.py?rev=19263&r1=19262&r2=19263&view=diff
==============================================================================
--- erp5/trunk/products/CMFActivity/ActivityTool.py (original)
+++ erp5/trunk/products/CMFActivity/ActivityTool.py Tue Feb 12 10:33:47 2008
@@ -209,16 +209,17 @@
       self.is_executed = 1
     except:
       self.is_executed = 0
-      self.exc_type = sys.exc_info()[0]
-      self.exc_value = str(sys.exc_info()[1])
+      exc_info = sys.exc_info()
+      self.exc_type = exc_info[0]
+      self.exc_value = str(exc_info[1])
       self.traceback = ''.join(ExceptionFormatter.format_exception(
-                               *sys.exc_info()))
+                               *exc_info))
       LOG('ActivityTool', WARNING,
           'Could not call method %s on object %s' % (
-          self.method_id, self.object_path), error=sys.exc_info())
+          self.method_id, self.object_path), error=exc_info)
       # push the error in ZODB error_log
       if getattr(activity_tool, 'error_log', None) is not None:
-        activity_tool.error_log.raising(sys.exc_info())
+        activity_tool.error_log.raising(exc_info)
 
   def validate(self, activity, activity_tool, check_order_validation=1):
     return activity.validate(activity_tool, self,