[Erp5-report] r19207 - /erp5/trunk/products/ERP5OOo/Document/OOoDocument.py

nobody at svn.erp5.org nobody at svn.erp5.org
Sat Feb 9 20:17:23 CET 2008


Author: jp
Date: Sat Feb  9 20:17:23 2008
New Revision: 19207

URL: http://svn.erp5.org?rev=19207&view=rev
Log:
Improvements for populateContent

Modified:
    erp5/trunk/products/ERP5OOo/Document/OOoDocument.py

Modified: erp5/trunk/products/ERP5OOo/Document/OOoDocument.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5OOo/Document/OOoDocument.py?rev=19207&r1=19206&r2=19207&view=diff
==============================================================================
--- erp5/trunk/products/ERP5OOo/Document/OOoDocument.py (original)
+++ erp5/trunk/products/ERP5OOo/Document/OOoDocument.py Sat Feb  9 20:17:23 2008
@@ -411,7 +411,8 @@
             data = z.read(fn)
             break
         mime = 'text/html'
-        self.populateContent(zip_file=z)
+        self.populateContent(zip_file=z) # Maybe some parts should be asynchronous for
+                                         # better usability
         z.close()
         cs.close()
       if (display is None or original_format not in STANDARD_IMAGE_FORMAT_LIST) \
@@ -474,13 +475,24 @@
         self.manage_delObjects([file_name])
       newContent = UnrestrictedMethod(self.portal_contributions.newContent)
       if file_name.endswith('html'):
-        newContent(id=file_name, container=self, portal_type='Web Page',
+        web_page = newContent(\
+                  id=file_name, container=self, portal_type='Web Page',
                   file_name=file_name,
                   data=zip_file.read(file_name))
+        if web_page.getValidationState() != 'embedded':
+          # Make sure embedded is set until cleaner solution if found
+          web_page.embed()
+        web_page.activate().disoverMetadata() # Maybe we should use contribution tool instead
+                                              # Should be embedded
       else:
-        newContent(id=file_name, container=self,
+        image_or_file = newContent(\
+                  id=file_name, container=self,
+                  portal_type='Image', # Contribution Tool would be better here
                   file_name=file_name,
                   data=zip_file.read(file_name))
+        if image_or_file.getValidationState() != 'embedded':
+          # Make sure embedded is set until cleaner solution if found
+          image_or_file.embed()
     if must_close:
       zip_file.close()
       archive_file.close()




More information about the Erp5-report mailing list