[Erp5-report] r19009 - /erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

[nobody at svn.erp5.org]

Author: vincent
Date: Sun Feb  3 07:42:53 2008
New Revision: 19009

URL: http://svn.erp5.org?rev=19009&view=rev
Log:
Iterate just once in method_id_list. This limits the number of values to keep in memory.

Modified:
    erp5/trunk/products/ZSQLCatalog/SQLCatalog.py

Modified: erp5/trunk/products/ZSQLCatalog/SQLCatalog.py
URL: http://svn.erp5.org/erp5/trunk/products/ZSQLCatalog/SQLCatalog.py?rev=19009&r1=19008&r2=19009&view=diff
==============================================================================
--- erp5/trunk/products/ZSQLCatalog/SQLCatalog.py (original)
+++ erp5/trunk/products/ZSQLCatalog/SQLCatalog.py Sun Feb  3 07:42:53 2008
@@ -1704,7 +1704,6 @@
       if not disable_cache:
         enableReadOnlyTransactionCache(self)
 
-      method_kw_dict = {}
       for method_name in method_id_list:
         kw = {}
         if self.isMethodFiltered(method_name):
@@ -1756,8 +1755,6 @@
         if len(catalogged_object_list) == 0:
           continue
 
-        method_kw_dict[method_name] = kw
-
         #LOG('catalogObjectList', 0, 'method_name = %s' % (method_name,))
         method = getattr(self, method_name)
         if method.meta_type in ("Z SQL Method", "LDIF Method"):
@@ -1788,9 +1785,6 @@
             append(value)
           kw[arg] = value_list
 
-      for method_name in method_kw_dict.keys():
-        kw = method_kw_dict[method_name]
-        method = getattr(self, method_name)
         method = aq_base(method).__of__(portal_catalog) # Use method in
                 # the context of portal_catalog
         # Alter/Create row