[Erp5-report] r17861 - in /erp5/trunk/products/ERP5Type: Accessor/ tests/

[nobody at svn.erp5.org]

Author: jerome
Date: Wed Nov 28 14:28:23 2007
New Revision: 17861

URL: http://svn.erp5.org?rev=17861&view=rev
Log:
Clarify the case of list/set accessors when no value is defined: they return None.


Modified:
    erp5/trunk/products/ERP5Type/Accessor/List.py
    erp5/trunk/products/ERP5Type/tests/testERP5Type.py

Modified: erp5/trunk/products/ERP5Type/Accessor/List.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/Accessor/List.py?rev=17861&r1=17860&r2=17861&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/Accessor/List.py (original)
+++ erp5/trunk/products/ERP5Type/Accessor/List.py Wed Nov 28 14:28:23 2007
@@ -310,7 +310,8 @@
 
     def __call__(self, instance, *args, **kw):
       result_list = ListGetter.__call__(self, instance, *args, **kw)
-      result_set = dict([(x, 0) for x in result_list]).keys()
-      return result_set
+      if result_list is not None:
+        result_set = dict([(x, 0) for x in result_list]).keys()
+        return result_set
 
 Tester = Base.Tester

Modified: erp5/trunk/products/ERP5Type/tests/testERP5Type.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/tests/testERP5Type.py?rev=17861&r1=17860&r2=17861&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/tests/testERP5Type.py (original)
+++ erp5/trunk/products/ERP5Type/tests/testERP5Type.py Wed Nov 28 14:28:23 2007
@@ -1699,16 +1699,18 @@
       self.assertTrue(hasattr(person, 'getDummyList'))
 
       self.assertEquals(person.getDummy(), None)
-      # self.assertEquals(person.getDummyList(), []) # XXX what is the default
-                                                     # value for a list getter ?
+      self.assertEquals(person.getDummyList(), None)
+      self.assertEquals(person.getDummySet(), None)
 
       person.setDummyList(['a', 'b'])
       self.assertEquals(person.getDummy(), 'a')
       self.assertEquals(person.getDummyList(), ['a', 'b'])
+      self.assertEquals(person.getDummySet(), ['a', 'b'])
 
       person.setDummy('value')
       self.assertEquals(person.getDummy(), 'value')
       self.assertEquals(person.getDummyList(), ['value'])
+      self.assertEquals(person.getDummySet(), ['value'])