[Erp5-report] r17643 - in /erp5/trunk/products/ERP5Form: ./ tests/

[nobody at svn.erp5.org]

Author: jp
Date: Fri Nov 16 07:58:56 2007
New Revision: 17643

URL: http://svn.erp5.org?rev=17643&view=rev
Log:
Fixed testPreferences test.

Modified:
    erp5/trunk/products/ERP5Form/PreferenceTool.py
    erp5/trunk/products/ERP5Form/tests/testPreferences.py

Modified: erp5/trunk/products/ERP5Form/PreferenceTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/PreferenceTool.py?rev=17643&r1=17642&r2=17643&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/PreferenceTool.py (original)
+++ erp5/trunk/products/ERP5Form/PreferenceTool.py Fri Nov 16 07:58:56 2007
@@ -128,6 +128,8 @@
       value = None
       for pref in instance._getSortedPreferenceList(*args, **kw):
         value = getattr(pref, self._preference_name, _marker)
+        # XXX-JPS Why don't we use accessors here such as:
+        # value = pref.getProperty(self._preference_name, _marker)
         if value is not _marker:
           # If callable, store the return value.
           if callable(value):

Modified: erp5/trunk/products/ERP5Form/tests/testPreferences.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Form/tests/testPreferences.py?rev=17643&r1=17642&r2=17643&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Form/tests/testPreferences.py (original)
+++ erp5/trunk/products/ERP5Form/tests/testPreferences.py Fri Nov 16 07:58:56 2007
@@ -386,7 +386,8 @@
     state_list = method()
     self.assertEquals(state_list, None)
     state_list = method(('default',))
-    self.assertEquals(state_list, ('default',))
+    self.assertEquals(state_list, ['default',]) # getPreferredAccountingTransactionSimulationStateList
+                                                # always tries to cast tuples to lists
  
     method = lambda *args: pref_tool.getPreference('preferred_accounting_transaction_simulation_state_list', *args)
     state_list = method()