[Erp5-report] r17373 - /erp5/trunk/products/ERP5Type/patches/WorkflowTool.py

[nobody at svn.erp5.org]

Author: vincent
Date: Fri Nov  2 18:25:40 2007
New Revision: 17373

URL: http://svn.erp5.org?rev=17373&view=rev
Log:
Add a warning about hardcoded values.
Add a forgotten security-related column.
Word-wrap at 80-car.

Modified:
    erp5/trunk/products/ERP5Type/patches/WorkflowTool.py

Modified: erp5/trunk/products/ERP5Type/patches/WorkflowTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/patches/WorkflowTool.py?rev=17373&r1=17372&r2=17373&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/patches/WorkflowTool.py (original)
+++ erp5/trunk/products/ERP5Type/patches/WorkflowTool.py Fri Nov  2 18:25:40 2007
@@ -543,8 +543,12 @@
     portal_catalog = getToolByName(self, 'portal_catalog')
     search_result = portal_catalog.unrestrictedSearchResults
     acceptable_key_dict = portal_catalog.getSQLCatalog().getColumnMap()
-    table_column_id_set = ImmutableSet([COUNT_COLUMN_TITLE, 'security_uid', 'simulation_state', 'validation_state', 'portal_type', 'owner'])
-    security_column_id_list = ['security_uid']
+    # XXX: those hardcoded lists should be grabbed from the table dynamicaly
+    # (and cached).
+    table_column_id_set = ImmutableSet([
+      COUNT_COLUMN_TITLE, 'security_uid', 'simulation_state',
+      'validation_state', 'portal_type', 'owner'])
+    security_column_id_list = ['security_uid', 'owner']
     (worklist_list_grouped_by_condition, worklist_metadata) = \
       groupWorklistListByCondition(
         worklist_dict=worklist_dict,