[Erp5-report] r16477 - in /erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm: ...

nobody at svn.erp5.org nobody at svn.erp5.org
Wed Sep 19 16:53:22 CEST 2007


Author: ivan
Date: Wed Sep 19 16:53:22 2007
New Revision: 16477

URL: http://svn.erp5.org?rev=16477&view=rev
Log:
Fix a cache related bug. (All <Portal_Type>_getResourceItemList method shared the same cache id. Use script id instead.)
Do no any longer call a statis script. Instead In Field library generate dynamicaly the respective getResourceItemList method id.
This prevented all CRM portal types based forms from getting the the same resource lists due to both cache and bad field library misconfiguration.

Modified:
    erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Campaign_getResourceItemList.xml
    erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Event_getResourceItemList.xml
    erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Meeting_getResourceItemList.xml
    erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SaleOpportunity_getResourceItemList.xml
    erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SupportRequest_getResourceItemList.xml
    erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Ticket_viewFieldLibrary/my_resource.xml

Modified: erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Campaign_getResourceItemList.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Campaign_getResourceItemList.xml?rev=16477&r1=16476&r2=16477&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Campaign_getResourceItemList.xml (original)
+++ erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Campaign_getResourceItemList.xml Wed Sep 19 16:53:22 2007
@@ -85,7 +85,7 @@
   return result\n
 \n
 getResourceItemList = CachingMethod(getResourceItemList, \n
-      id=(\'Event_getResourceItemList\', context.Localizer.get_selected_language()), \n
+      id=(script.id, context.Localizer.get_selected_language()), \n
       cache_factory=\'erp5_ui_long\')\n
                                  \n
 return getResourceItemList()\n
@@ -135,6 +135,7 @@
                             <string>CachingMethod</string>
                             <string>getResourceItemList</string>
                             <string>_getattr_</string>
+                            <string>script</string>
                             <string>context</string>
                           </tuple>
                         </value>

Modified: erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Event_getResourceItemList.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Event_getResourceItemList.xml?rev=16477&r1=16476&r2=16477&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Event_getResourceItemList.xml (original)
+++ erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Event_getResourceItemList.xml Wed Sep 19 16:53:22 2007
@@ -85,7 +85,7 @@
   return result\n
 \n
 getResourceItemList = CachingMethod(getResourceItemList, \n
-      id=(\'Event_getResourceItemList\', context.Localizer.get_selected_language()), \n
+      id=(script.id, context.Localizer.get_selected_language()), \n
       cache_factory=\'erp5_ui_long\')\n
                                  \n
 return getResourceItemList()\n
@@ -135,6 +135,7 @@
                             <string>CachingMethod</string>
                             <string>getResourceItemList</string>
                             <string>_getattr_</string>
+                            <string>script</string>
                             <string>context</string>
                           </tuple>
                         </value>

Modified: erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Meeting_getResourceItemList.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Meeting_getResourceItemList.xml?rev=16477&r1=16476&r2=16477&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Meeting_getResourceItemList.xml (original)
+++ erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Meeting_getResourceItemList.xml Wed Sep 19 16:53:22 2007
@@ -85,7 +85,7 @@
   return result\n
 \n
 getResourceItemList = CachingMethod(getResourceItemList, \n
-      id=(\'Event_getResourceItemList\', context.Localizer.get_selected_language()), \n
+      id=(script.id, context.Localizer.get_selected_language()), \n
       cache_factory=\'erp5_ui_long\')\n
                                  \n
 return getResourceItemList()\n
@@ -135,6 +135,7 @@
                             <string>CachingMethod</string>
                             <string>getResourceItemList</string>
                             <string>_getattr_</string>
+                            <string>script</string>
                             <string>context</string>
                           </tuple>
                         </value>

Modified: erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SaleOpportunity_getResourceItemList.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SaleOpportunity_getResourceItemList.xml?rev=16477&r1=16476&r2=16477&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SaleOpportunity_getResourceItemList.xml (original)
+++ erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SaleOpportunity_getResourceItemList.xml Wed Sep 19 16:53:22 2007
@@ -85,7 +85,7 @@
   return result\n
 \n
 getResourceItemList = CachingMethod(getResourceItemList, \n
-      id=(\'Event_getResourceItemList\', context.Localizer.get_selected_language()), \n
+      id=(script.id, context.Localizer.get_selected_language()), \n
       cache_factory=\'erp5_ui_long\')\n
                                  \n
 return getResourceItemList()\n
@@ -135,6 +135,7 @@
                             <string>CachingMethod</string>
                             <string>getResourceItemList</string>
                             <string>_getattr_</string>
+                            <string>script</string>
                             <string>context</string>
                           </tuple>
                         </value>

Modified: erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SupportRequest_getResourceItemList.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SupportRequest_getResourceItemList.xml?rev=16477&r1=16476&r2=16477&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SupportRequest_getResourceItemList.xml (original)
+++ erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/SupportRequest_getResourceItemList.xml Wed Sep 19 16:53:22 2007
@@ -85,7 +85,7 @@
   return result\n
 \n
 getResourceItemList = CachingMethod(getResourceItemList, \n
-      id=(\'Event_getResourceItemList\', context.Localizer.get_selected_language()), \n
+      id=(script.id, context.Localizer.get_selected_language()), \n
       cache_factory=\'erp5_ui_long\')\n
                                  \n
 return getResourceItemList()\n
@@ -135,6 +135,7 @@
                             <string>CachingMethod</string>
                             <string>getResourceItemList</string>
                             <string>_getattr_</string>
+                            <string>script</string>
                             <string>context</string>
                           </tuple>
                         </value>

Modified: erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Ticket_viewFieldLibrary/my_resource.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Ticket_viewFieldLibrary/my_resource.xml?rev=16477&r1=16476&r2=16477&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Ticket_viewFieldLibrary/my_resource.xml (original)
+++ erp5/trunk/bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Ticket_viewFieldLibrary/my_resource.xml Wed Sep 19 16:53:22 2007
@@ -68,7 +68,7 @@
                     <value> <string></string> </value>
                 </item>
                 <item>
-                    <key> <string>items</string> </key>
+                    <key>                 <string>items</string> </key>
                     <value>
                       <persistent> <string encoding="base64">AAAAAAAAAAI=</string> </persistent>
                     </value>
@@ -78,7 +78,7 @@
                     <value> <string></string> </value>
                 </item>
                 <item>
-                    <key> <string>title</string> </key>
+                    <key>                 <string>title</string> </key>
                     <value>
                       <persistent> <string encoding="base64">AAAAAAAAAAM=</string> </persistent>
                     </value>
@@ -99,7 +99,7 @@
                     <value> <string>Base_viewFieldLibrary</string> </value>
                 </item>
                 <item>
-                    <key>                 <string>items</string> </key>
+                    <key> <string>items</string> </key>
                     <value>
                       <list>
                         <tuple>
@@ -118,7 +118,7 @@
                     <value> <string>Click to edit the target</string> </value>
                 </item>
                 <item>
-                    <key>                 <string>title</string> </key>
+                    <key> <string>title</string> </key>
                     <value> <string>Ticket Type</string> </value>
                 </item>
               </dictionary>
@@ -141,7 +141,7 @@
       <dictionary>
         <item>
             <key> <string>_text</string> </key>
-            <value> <string>here/Campaign_getResourceItemList</string> </value>
+            <value> <string>python: getattr(here, \'%s_getResourceItemList\' %here.getPortalType().replace(\' \',\'\'))()</string> </value>
         </item>
       </dictionary>
     </pickle>




More information about the Erp5-report mailing list