[Erp5-report] r15406 - /erp5/trunk/products/ERP5Catalog/CatalogTool.py

[nobody at svn.erp5.org]

Author: vincent
Date: Wed Aug  1 09:25:25 2007
New Revision: 15406

URL: http://svn.erp5.org?rev=15406&view=rev
Log:
Avoid unneeded function calls in inner loop.

Modified:
    erp5/trunk/products/ERP5Catalog/CatalogTool.py

Modified: erp5/trunk/products/ERP5Catalog/CatalogTool.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Catalog/CatalogTool.py?rev=15406&r1=15405&r2=15406&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Catalog/CatalogTool.py (original)
+++ erp5/trunk/products/ERP5Catalog/CatalogTool.py Wed Aug  1 09:25:25 2007
@@ -416,6 +416,7 @@
       user = _getAuthenticatedUser(self)
       allowedRolesAndUsers = self._listAllowedRolesAndUsers(user)
       role_column_dict = {}
+      column_map = self.getSQLCatalog().getColumnMap()
 
       # Patch for ERP5 by JP Smets in order
       # to implement worklists and search of local roles
@@ -433,7 +434,7 @@
             for role in local_roles:
               # Performance optimisation
               lower_role = role.lower()
-              if self.getSQLCatalog().getColumnMap().has_key(lower_role):
+              if lower_role in column_map:
                 # If a given role exists as a column in the catalog,
                 # then it is considered as single valued and indexed
                 # through the catalog.