[Erp5-report] r14805 - in /erp5/trunk/bt5/erp5_banking_core: SkinTemplateItem/portal_skins/...

[nobody at svn.erp5.org]

Author: aurel
Date: Wed Jun 13 12:50:58 2007
New Revision: 14805

URL: http://svn.erp5.org?rev=14805&view=rev
Log:
when generating reference, do not reuse old one as it can lead to strange reference generation if reference depends on a parameter the user can play with

Modified:
    erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Baobab_getUniqueReference.xml
    erp5/trunk/bt5/erp5_banking_core/bt/revision

Modified: erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Baobab_getUniqueReference.xml
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Baobab_getUniqueReference.xml?rev=14805&r1=14804&r2=14805&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Baobab_getUniqueReference.xml (original)
+++ erp5/trunk/bt5/erp5_banking_core/SkinTemplateItem/portal_skins/erp5_banking_core/Baobab_getUniqueReference.xml Wed Jun 13 12:50:58 2007
@@ -102,12 +102,15 @@
         return \'\'\n
 \n
   # actual generation\n
-  if reference in (None, \'\'):\n
-    baobab_id_group = (application_id, codification, year)\n
-    reference = context.portal_ids.generateNewLengthId(id_group = baobab_id_group)\n
+  #if reference in (None, \'\'): \n
+  #XXX is it necessary to concatenate to an old reference ?\n
+  # this make reference look strange when using different script to\n
+  # generate reference based on criteria the user can play with\n
+  baobab_id_group = (application_id, codification, year)\n
+  new_id = context.portal_ids.generateNewLengthId(id_group = baobab_id_group)\n
 \n
   # affectation\n
-  reference = "%s-%s-%s-%s" % (application_id, codification, year, reference)\n
+  reference = "%s-%s-%s-%s" % (application_id, codification, year, new_id)\n
   context.setSourceReference(reference)\n
 \n
 # finally, return it\n
@@ -179,6 +182,7 @@
                             <string>site</string>
                             <string>site_value</string>
                             <string>baobab_id_group</string>
+                            <string>new_id</string>
                           </tuple>
                         </value>
                     </item>

Modified: erp5/trunk/bt5/erp5_banking_core/bt/revision
URL: http://svn.erp5.org/erp5/trunk/bt5/erp5_banking_core/bt/revision?rev=14805&r1=14804&r2=14805&view=diff
==============================================================================
--- erp5/trunk/bt5/erp5_banking_core/bt/revision (original)
+++ erp5/trunk/bt5/erp5_banking_core/bt/revision Wed Jun 13 12:50:58 2007
@@ -1,1 +1,1 @@
-276
+277