From arnaud.fontaine at nexedi.com Wed Sep 11 08:47:31 2013 From: arnaud.fontaine at nexedi.com (Arnaud Fontaine) Date: Wed, 11 Sep 2013 15:47:31 +0900 Subject: [Erp5-dev] cherry-pick request: EmailReader compatability with various ImapServers is improved In-Reply-To: <20130901204035.GA18601@bk-ssd40.localdomain> (Boris Kocherov's message of "Mon, 2 Sep 2013 00:40:35 +0400") References: <20130901204035.GA18601@bk-ssd40.localdomain> Message-ID: <87hadr6eik.fsf@duckcorp.org> Hello, Really sorry for the late reply. Boris Kocherov writes: > https://www.raskon.org/gitweb/?p=erp5.git;a=commit;h=193ffe5df78e401bfe750cd8348085dc58940458 Thank you very much for this patch. I have applied this patch to my branch ('arnau'). To be honest, I don't know so much about IMAP nor erp5_email_reader, so before merging it I have some questions: * Where is '/' used as a delimiter instead of '.'? (out of curiosity as I have never seen that yet) * Why 'ALL' instead of '( ALL )'? * Another change done in this commit is about handling multiple flags? Thanks! Regards, -- Arnaud Fontaine From bk at raskon.org Wed Sep 11 10:29:49 2013 From: bk at raskon.org (Boris Kocherov) Date: Wed, 11 Sep 2013 12:29:49 +0400 Subject: [Erp5-dev] cherry-pick request: EmailReader compatability with various ImapServers is improved In-Reply-To: <87hadr6eik.fsf@duckcorp.org> References: <20130901204035.GA18601@bk-ssd40.localdomain> <87hadr6eik.fsf@duckcorp.org> Message-ID: <20130911082949.GA17286@bk-ssd40.localdomain> On 11/09/13 15:47, Arnaud Fontaine wrote: > Thank you very much for this patch. I have applied this patch to my > branch ('arnau'). To be honest, I don't know so much about IMAP nor > erp5_email_reader, so before merging it I have some questions: > > * Where is '/' used as a delimiter instead of '.'? (out of curiosity as > I have never seen that yet) imap.mail.ru and "very rarely used" imap.gmail.com > * Why 'ALL' instead of '( ALL )'? gmail.com does not support '( ALL )'. Dovecot server support both variants. > * Another change done in this commit is about handling multiple flags? Does not. It can be needed for future. IMAP implementation have another not important issue: Multilingual charachters are not correctly displayed in folders names. Best regards, Boris Kocherov -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: From bk at raskon.org Wed Sep 11 10:50:08 2013 From: bk at raskon.org (Boris Kocherov) Date: Wed, 11 Sep 2013 12:50:08 +0400 Subject: [Erp5-dev] cherry-pick request: add TemplateTool_filterEmptyContentTranslation script Message-ID: <20130911085008.GB17286@bk-ssd40.localdomain> https://www.raskon.org/gitweb/?p=erp5.git;a=commit;h=41c3783e0b6e9da7024218c3be7df28a75892ef1 for filter empty content_translation dictonaries in vcs -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: From arnaud.fontaine at nexedi.com Wed Sep 11 11:15:06 2013 From: arnaud.fontaine at nexedi.com (Arnaud Fontaine) Date: Wed, 11 Sep 2013 18:15:06 +0900 Subject: [Erp5-dev] cherry-pick request: EmailReader compatability with various ImapServers is improved In-Reply-To: <20130911082949.GA17286@bk-ssd40.localdomain> (Boris Kocherov's message of "Wed, 11 Sep 2013 12:29:49 +0400") References: <20130901204035.GA18601@bk-ssd40.localdomain> <87hadr6eik.fsf@duckcorp.org> <20130911082949.GA17286@bk-ssd40.localdomain> Message-ID: <87y573zplx.fsf@duckcorp.org> Hello, Boris Kocherov writes: > On 11/09/13 15:47, Arnaud Fontaine wrote: >> Thank you very much for this patch. I have applied this patch to my >> branch ('arnau'). To be honest, I don't know so much about IMAP nor >> erp5_email_reader, so before merging it I have some questions: >> >> * Where is '/' used as a delimiter instead of '.'? (out of curiosity as >> I have never seen that yet) > imap.mail.ru > and "very rarely used" imap.gmail.com > >> * Why 'ALL' instead of '( ALL )'? > gmail.com does not support '( ALL )'. > Dovecot server support both variants. > >> * Another change done in this commit is about handling multiple flags? > Does not. It can be needed for future. > > IMAP implementation have another not important issue: > Multilingual charachters are not correctly displayed in folders names. Thanks for your reply. Would it be ok if I change the commit message based on your reply (it will be merged anyhow): EmailReader compatibility with various ImapServers is improved. * imap.mail.ru and imap.gmail.com (very rarely) use '/' as a delimiter. * gmail.com does not support '( ALL )', use 'ALL' instead. * Handle multiple flags. Regards, -- Arnaud Fontaine From bk at raskon.org Wed Sep 11 11:52:25 2013 From: bk at raskon.org (Boris Kocherov) Date: Wed, 11 Sep 2013 13:52:25 +0400 Subject: [Erp5-dev] cherry-pick request: EmailReader compatability with various ImapServers is improved In-Reply-To: <87y573zplx.fsf@duckcorp.org> References: <20130901204035.GA18601@bk-ssd40.localdomain> <87hadr6eik.fsf@duckcorp.org> <20130911082949.GA17286@bk-ssd40.localdomain> <87y573zplx.fsf@duckcorp.org> Message-ID: <20130911095225.GA25599@bk-ssd40.localdomain> On 11/09/13 18:15, Arnaud Fontaine wrote: > Thanks for your reply. Would it be ok if I change the commit message > based on your reply (it will be merged anyhow): > > EmailReader compatibility with various ImapServers is improved. > > * imap.mail.ru and imap.gmail.com (very rarely) use '/' as a delimiter. > * gmail.com does not support '( ALL )', use 'ALL' instead. > * Handle multiple flags. and "very rarely used" imap.gmail.com - it was just a joke that gmail.com is rarely used. NO preposition 'BY' in the previous sentence, so your phrase "imap.mail.ru and imap.gmail.com (very rarely) use '/' as a delimiter" isn't correct. Many free famous imap services use '/' as a delimiter, gmail.com and mail.ru - among this services. my version message: EmailReader compatibility with various ImapServers is improved. * imap.mail.ru and imap.gmail.com use '/' as a delimiter. * gmail.com does not support '( ALL )', use 'ALL' instead. * parse multiple flags. PS. no more ironic jokes Best regards, Boris Kocherov -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: