[Erp5-dev] bugfix: dramaticly increase speed upgrading through TemplateTool from repositories

Vincent Pelletier vincent at nexedi.com
Fri Sep 19 04:40:55 CEST 2008


Hi.

This fix looks strange to me:
 - why moving object_list definition down "one" line ?
 - why adding an "i" variable initialisation without changing the one already 
present in the loop (I believe one should go away) ?

Or... Maybe it wasn't the patch you intended to send ?

I guess the copy/paste you mention are the "line.edit" calls, which would mean 
that only choice_item_list would be in the big "if" block.
But I admit that even then I don't see why it would increase speed (still it's 
worth doing since it increases maintainability).

-- 
Vincent Pelletier



More information about the Erp5-dev mailing list